mbrobbel commented on PR #14065:
URL: https://github.com/apache/datafusion/pull/14065#issuecomment-2582417847
> > > @jonahgao does linter pass in your local after this change?
> >
> >
> > Yes, it passed. Do you encounter any issues?
>
> ```
> cargo clippy --all-targets --workspace --features avro,pyarrow -- -D
warnings
> Checking ffi_module_interface v0.1.0
(/Users/berkaysahin/Desktop/datafusion/datafusion-examples/examples/ffi/ffi_module_interface)
> Checking datafusion-wasmtest v44.0.0
(/Users/berkaysahin/Desktop/datafusion/datafusion/wasmtest)
> Checking datafusion-ffi v44.0.0
(/Users/berkaysahin/Desktop/datafusion/datafusion/ffi)
> Checking datafusion-benchmarks v44.0.0
(/Users/berkaysahin/Desktop/datafusion/benchmarks)
> error: unexpected `cfg` condition name:
`wasm_bindgen_unstable_test_coverage`
> --> datafusion/wasmtest/src/lib.rs:47:1
> |
> 47 | #[wasm_bindgen]
> | ^^^^^^^^^^^^^^^
> |
> = help: expected names are: `clippy`, `debug_assertions`, `doc`,
`docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`,
`panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`,
`sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`,
`target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`,
`target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`,
`target_has_atomic_load_store`, `target_os`, `target_pointer_width`,
`target_thread_local`, `target_vendor`, `tarpaulin`, `test`, `ub_checks`,
`unix`, and `windows`
> = help: consider using a Cargo feature instead
> = help: or consider adding in `Cargo.toml` the `check-cfg` lint config
for the lint:
> [lints.rust]
> unexpected_cfgs = { level = "warn", check-cfg =
['cfg(wasm_bindgen_unstable_test_coverage)'] }
> = help: or consider adding
`println!("cargo::rustc-check-cfg=cfg(wasm_bindgen_unstable_test_coverage)");`
to the top of the `build.rs`
> = note: see
<https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for
more information about checking conditional configuration
> = note: `-D unexpected-cfgs` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
> = note: this error originates in the attribute macro `wasm_bindgen` (in
Nightly builds, run with -Z macro-backtrace for more info)
>
> error: unexpected `cfg` condition name:
`wasm_bindgen_unstable_test_coverage`
> --> datafusion/wasmtest/src/lib.rs:67:1
> |
> 67 | #[wasm_bindgen]
> | ^^^^^^^^^^^^^^^
> |
> = help: consider using a Cargo feature instead
> = help: or consider adding in `Cargo.toml` the `check-cfg` lint config
for the lint:
> [lints.rust]
> unexpected_cfgs = { level = "warn", check-cfg =
['cfg(wasm_bindgen_unstable_test_coverage)'] }
> = help: or consider adding
`println!("cargo::rustc-check-cfg=cfg(wasm_bindgen_unstable_test_coverage)");`
to the top of the `build.rs`
> = note: see
<https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for
more information about checking conditional configuration
> = note: this error originates in the attribute macro `wasm_bindgen` (in
Nightly builds, run with -Z macro-backtrace for more info)
>
> error: could not compile `datafusion-wasmtest` (lib) due to 2 previous
errors
> warning: build failed, waiting for other jobs to finish...
> error: could not compile `datafusion-wasmtest` (lib test) due to 2
previous errors
> ```
>
> These unexpected cfg conditions are changing at each try. I couldn't
quickly understand the reason of these errors.
Can you try again after `cargo update wasm-bindgen`? This was fixed in
https://github.com/rustwasm/wasm-bindgen/pull/4284.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
