logan-keede commented on code in PR #14190:
URL: https://github.com/apache/datafusion/pull/14190#discussion_r1921648964
##########
datafusion/physical-optimizer/Cargo.toml:
##########
@@ -48,6 +49,7 @@ futures = { workspace = true }
itertools = { workspace = true }
log = { workspace = true }
recursive = { workspace = true, optional = true }
+parquet = { workspace = true, optional = true, default-features = true }
Review Comment:
Tests have dependency on `EnforceSorting`, hence waiting for #14185 .
Alternatively, I could load `EnforceSorting` directly from core but due to
re-export of `physical_plan_optimizer` compiler tries to find it in
`[datafusion/datafusion/physical-optimizer/src/enforce_sorting.rs]` instead of
[`datafusion/datafusion/core/src/physical_optimizer/enforce_sorting.rs`](https://github.com/apache/datafusion/blob/main/datafusion/core/src/physical_optimizer/enforce_sorting.rs)
so I would have to undo the re-exporting and change every line that consider
re-export.
That creates distinction between two module that should help in refactoring
but I am not sure if that is the ideal way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
