cht42 commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1922736225
##########
datafusion/functions/src/string/concat_ws.rs:
##########
@@ -317,7 +318,19 @@ fn simplify_concat_ws(delimiter: &Expr, args: &[Expr]) ->
Result<ExprSimplifyRes
match delimiter {
// when the delimiter is an empty string,
// we can use `concat` to replace `concat_ws`
- Some(delimiter) if delimiter.is_empty() =>
simplify_concat(args.to_vec()),
+ Some(delimiter) if delimiter.is_empty() => {
Review Comment:
`simplify_concat` will return the orginial if no simplification is done
which in our case calling `concat_ws` with the args and not the delimiter
https://github.com/apache/datafusion/blob/acf66d66537221ee7501a3be2e08c065a49efd4b/datafusion/functions/src/string/concat.rs#L371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
