logan-keede commented on issue #12752:
URL: https://github.com/apache/datafusion/issues/12752#issuecomment-2610961776
Update:- it is 4 as of commit 44cf77feb3d521a4b25f3b192a753747687285b2 (DF44)
```
Completed in 8 seconds
\
Execution error: Error completing "join.slt": failed to rename file from
test_files/join.slt.temp to test_files/join.slt: No such file or directory (os
error 2)
Execution error: Error completing "string/string.slt": failed to rename file
from test_files/string/init_data.slt.part.temp to
test_files/string/./init_data.slt.part: No such file or directory (os error 2)
Execution error: Error completing "string/string_view.slt": failed to rename
file from test_files/string/string_query.slt.part.temp to
test_files/string/./string_query.slt.part: No such file or directory (os error
2)
Execution error: Error completing "string/dictionary_utf8.slt": failed to
rename file from test_files/string/string_query.slt.part.temp to
test_files/string/./string_query.slt.part: No such file or directory (os error
2)
Error: Execution("4 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test
sqllogictests`
```
## Analysis
1. `Error completing "join.slt"` seems to be stemming fro the fact that
`datafusion/sqllogictest/test_files/join_disable_repartition_joins.slt` seems
to be including it but it is not a part file so it fails to do so.
2. rest of them occur because `sqllogictest` run these tests asynchronously
and multiple files try to include `string_query.slt.part` and
`init_data.slt.part` which result in them renaming them to clashing names and
then one of them delete a temp file while other tries to find it. (I just
checked it runs perfectly on one thread but takes a whole minute)
## Possible solution
1. rename `join.slt` to `join.slt.part`
2. we can just leave it as is and run the in 1 thread when really needed
3. or separate files that need to be run in synchronous manner
4. or allow redundant code and eliminate include statement
5. or merge them into one file somehow
cc @jayzhan211 @Omega359 @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
