logan-keede commented on code in PR #14543:
URL: https://github.com/apache/datafusion/pull/14543#discussion_r1947182581
##########
datafusion/core/src/datasource/data_source.rs:
##########
@@ -62,4 +62,8 @@ pub trait FileSource: Send + Sync {
fn fmt_extra(&self, _t: DisplayFormatType, _f: &mut Formatter) ->
fmt::Result {
Ok(())
}
+ /// Check if repartition is supported
+ fn supports_repartition(&self, config: &FileScanConfig) -> bool {
+ !(config.file_compression_type.is_compressed() ||
config.new_lines_in_values)
+ }
Review Comment:
I will try to include it in my next PR, which should be tomorrow hopefully.
just for clarity do you want to implement something like this for other
supported file format
```
fn supports_repartition(&self, config: &FileScanConfig) -> bool {
!(config.file_compression_type.is_compressed())
}
```
and original for csv. I do not have much context on this function, So i can
not comment on whether newlines is useful only in csv or not. I will try to
look into it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
