parthchandra commented on PR #1387: URL: https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2655953229
I applied this PR to my working branch : https://github.com/parthchandra/datafusion-comet/commits/complex_test_failures_with_PR1387/ The branch contains all the changes in https://github.com/apache/datafusion-comet/pull/1376 and some additional fixes I have been working on. The results are: native_datafusion: *** 18 TESTS FAILED *** native_iceberg_compat: *** 27 TESTS FAILED *** The differences are due to 5 tests related to 1) runs of `- fix: native Unsafe row accessors return incorrect results` which seems to fallback to Spark with native_datafusion (and so always succeeds). 2) 6 tests related to int96 fail in native_iceberg_compat. The failure might be related to the Spark configuration - `PARQUET_INT96_TIMESTAMP_CONVERSION i.e "spark.sql.parquet.int96TimestampConversion"` Investigating this, but it is unlikely to be related to this PR. So it looks like this PR does not have a negative impact on `native_iceberg_compat` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
