berkaysynnada commented on code in PR #14735:
URL: https://github.com/apache/datafusion/pull/14735#discussion_r1966895161
##########
datafusion-examples/examples/expr_api.rs:
##########
@@ -347,14 +350,112 @@ fn boundary_analysis_and_selectivity_demo() ->
Result<()> {
Ok(())
}
-fn make_field(name: &str, data_type: DataType) -> Field {
- let nullable = false;
- Field::new(name, data_type, nullable)
-}
+/// This function shows how to think about and leverage the analysis API
+/// to infer boundaries in `AND` & `OR` conjunctions.
+fn bounday_analysis_in_conjuctions_demo() -> Result<()> {
Review Comment:
```suggestion
fn boundary_analysis_in_conjuctions_demo() -> Result<()> {
```
##########
datafusion-examples/examples/expr_api.rs:
##########
@@ -84,6 +84,9 @@ async fn main() -> Result<()> {
// See how to analyze boundaries in different kinds of expressions.
boundary_analysis_and_selectivity_demo()?;
+ // See how boundary analysis works for `AND` & `OR` conjunctions.
+ bounday_analysis_in_conjuctions_demo()?;
Review Comment:
```suggestion
boundary_analysis_in_conjuctions_demo()?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
