cetra3 commented on code in PR #14783:
URL: https://github.com/apache/datafusion/pull/14783#discussion_r1967088349
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -1624,9 +1624,7 @@ impl Unparser<'_> {
DataType::Union(_, _) => {
not_impl_err!("Unsupported DataType: conversion:
{data_type:?}")
}
- DataType::Dictionary(_, _) => {
- not_impl_err!("Unsupported DataType: conversion:
{data_type:?}")
- }
+ DataType::Dictionary(_, val) => self.arrow_dtype_to_ast_dtype(val),
Review Comment:
I've added a test for this. Let me know if I need to flesh it out more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
