wForget commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1976892621
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -62,13 +62,9 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
Math.max((executorMemory * memoryOverheadFactor).toLong,
memoryOverheadMinMib)
}
+ // shouldOverrideMemoryConf guarantees that Comet is unified mode is
disabled
val cometMemOverhead =
- if
(!CometSparkSessionExtensions.cometUnifiedMemoryManagerEnabled(sc.getConf)) {
- CometSparkSessionExtensions.getCometMemoryOverheadInMiB(sc.getConf)
- } else {
- // comet shuffle unified memory manager is disabled, so we need to
add overhead memory
- CometSparkSessionExtensions.getCometShuffleMemorySize(sc.getConf)
- }
+ CometSparkSessionExtensions.getCometShuffleMemorySizeInMiB(sc.getConf)
Review Comment:
`getCometShuffleMemorySizeInMiB` is only used for shuffle memory, we should
also consider using `getCometMemoryOverheadInMiB` when unified memory manager
is disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
