alamb commented on code in PR #14954:
URL: https://github.com/apache/datafusion/pull/14954#discussion_r1977405243
##########
datafusion-cli/src/print_format.rs:
##########
@@ -209,14 +211,175 @@ impl PrintFormat {
}
Ok(())
}
+
+ #[allow(clippy::too_many_arguments)]
+ pub fn process_batch(
Review Comment:
Given that we now have some more time, I wonder if you could potentially
consider refactoring this code now.
- https://github.com/apache/datafusion/issues/14886
I found it somewhat hard to understand when I was trying to debug why the
explain plans were not showing up reasonably.
##########
datafusion-cli/src/print_options.rs:
##########
@@ -127,9 +107,125 @@ impl PrintOptions {
Ok(())
}
+ pub async fn print_table_batch(
Review Comment:
Could you add some comments here, as well as how it is different than
`print_batches`
##########
datafusion-cli/src/print_options.rs:
##########
@@ -110,7 +90,7 @@ impl PrintOptions {
self.format
Review Comment:
One thing I noticed when reviewing this code is that there are different
passes for print_batches and `print_table_batch`
I wonder if there is some way to combine them (so we always use the same
printing logic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
