timsaucer commented on code in PR #1016:
URL:
https://github.com/apache/datafusion-python/pull/1016#discussion_r1983241187
##########
src/dataframe.rs:
##########
@@ -50,6 +52,22 @@ use crate::{
expr::{sort_expr::PySortExpr, PyExpr},
};
+#[pyclass(name = "TableProvider", module = "datafusion")]
+pub struct PyTableProvider {
+ provider: Arc<dyn TableProvider>,
+}
+
+impl PyTableProvider {
+ pub fn new(provider: Arc<dyn TableProvider>) -> Self {
+ Self { provider }
+ }
+
+ pub fn as_table(&self) -> PyTable {
+ let table_provider: Arc<dyn TableProvider> = self.provider.clone();
+ PyTable::new(table_provider)
+ }
+}
+
Review Comment:
Otherwise I think we have to plan for how we can have a common concept
around two ways of creating table providers in python code. Also we would want
to think about how we would handle the return type of a udtf, which we haven't
even addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
