ctsk commented on PR #15022:
URL: https://github.com/apache/datafusion/pull/15022#issuecomment-2704252586
IMO the downside of this approach is that it allows to misuse the interface
- it shouldn't be possible to call `register_metadata` after calling
`update_batch`.
I don't quite see the issue with passing the `Metadata` in a constructor
- for `GroupsAccumulatorAdapter` add a `new_with_metadata`
- for aggregates that provide a `GroupsAccumulator` themselves, add a
`create_groups_accumulator_with_metadata` that falls back to
`create_groups_accumulator`
That should work without breaking API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
