2010YOUY01 commented on PR #15140: URL: https://github.com/apache/datafusion/pull/15140#issuecomment-2712575632
Thank you for making this happen. I have a suggestion: I think the only field needed inside `SPM` is the sort keys, how about making it consistent with those in `SortExec`? https://github.com/apache/datafusion/pull/15077/files#diff-1e143b33b083f63548925777992d4b79de3eb3fccbdcf37d35eff841717533d2 1. Use `sort keys` instead of `expr` to be more explicit 2. If there are multiple sort key, print them together like `sort keys: col1 asc nulls first, col2 desc nulls last` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
