alamb commented on code in PR #15206: URL: https://github.com/apache/datafusion/pull/15206#discussion_r1993896191
########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1711,35 +1711,58 @@ physical_plan query TT explain COPY (VALUES (1, 'foo', 1, '2023-01-01'), (2, 'bar', 2, '2023-01-02'), (3, 'baz', 3, '2023-01-03')) -TO 'test_files/scratch/explain_tree/1.json'; +TO '/tmp/1.json'; ---- physical_plan 01)┌───────────────────────────┐ 02)│ DataSinkExec │ -03)└─────────────┬─────────────┘ -04)┌─────────────┴─────────────┐ -05)│ DataSourceExec │ -06)│ -------------------- │ -07)│ bytes: 2672 │ -08)│ format: memory │ -09)│ rows: 1 │ -10)└───────────────────────────┘ +03)│ -------------------- │ +04)│ file:///tmp/1.json │ Review Comment: Can we also possibly add `format: csv` ? ########## datafusion/sqllogictest/test_files/explain_tree.slt: ########## @@ -1711,35 +1711,58 @@ physical_plan query TT explain COPY (VALUES (1, 'foo', 1, '2023-01-01'), (2, 'bar', 2, '2023-01-02'), (3, 'baz', 3, '2023-01-03')) -TO 'test_files/scratch/explain_tree/1.json'; +TO '/tmp/1.json'; Review Comment: Yeah, we need to avoid printing the entire path. Let me see if I can find some way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
