goldmedal commented on code in PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#discussion_r1998987034
##########
.github/workflows/rust.yml:
##########
@@ -246,6 +246,7 @@ jobs:
mc cp -r /source/* localminio/data"
- name: Run tests (excluding doctests)
env:
+ RUST_MIN_STACK: 4194304
Review Comment:
This test has been modified in the `main` branch. It seems that it never
happens stack overflow anymore.
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -94,6 +94,7 @@ impl Unparser<'_> {
Ok(root_expr)
}
+ #[cfg_attr(feature = "recursive_protection", recursive::recursive)]
Review Comment:
This annotation should be enabled by using the `recursive_protection`
feature. I found the CI doesn't enable it. I experimented with it
https://github.com/apache/datafusion/pull/15272 (It seems to work well)
You can see how I modified the workflow.
##########
.github/workflows/extended.yml:
##########
@@ -81,6 +81,7 @@ jobs:
- name: Run tests (excluding doctests)
env:
RUST_BACKTRACE: 1
+ RUST_MIN_STACK: 4194304
Review Comment:
After enabling `recursive_protection`, it can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
