Blizzara commented on code in PR #15211:
URL: https://github.com/apache/datafusion/pull/15211#discussion_r2004246503
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1074,6 +1074,9 @@ pub async fn from_project_rel(
// leaving only explicit expressions.
let mut explicit_exprs: Vec<Expr> = vec![];
+ // For WindowFunctions, we need to wrap them in a Window relation. If
there are duplicates,
+ // we can do the window'ing only once, then the project will duplicate
the result.
+ let mut window_exprs: HashSet<Expr> = HashSet::new();
Review Comment:
Hm, I don't think it matters per se, since the project below then puts
things into right places based on the names. However, for consistency it might
be nice for the order to stay. Let me see if I can quickly do that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
