Re: [PR] fix: `core_expressions` feature flag broken, move `overlay` into `core` functions [datafusion]

[via GitHub]

shruti2522 commented on PR #15217:
URL: https://github.com/apache/datafusion/pull/15217#issuecomment-2746480965

   > > hey @alamb, I have already added a re-export at the end of 
`datafusion/functions/src/string/overlay.rs` like this
   > 
   > Thanks @shruti2522 - that looks good to me
   > 
   > I double checked and it is appearing as we would expect
   > 
   > ![Screenshot 2025-03-18 at 3 43 22 
PM](https://private-user-images.githubusercontent.com/490673/424162612-2fc77338-9fcc-4e2d-976a-87158e88f76a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDI3NjY0MTIsIm5iZiI6MTc0Mjc2NjExMiwicGF0aCI6Ii80OTA2NzMvNDI0MTYyNjEyLTJmYzc3MzM4LTlmY2MtNGUyZC05NzZhLTg3MTU4ZTg4Zjc2YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMzIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDMyM1QyMTQxNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNzk5YjViM2YxOGM4NWQyOGU4ODU3Mjc2OTNhYmY2YjYyNmRkYzUwZTg5MWMwNWNkNTQxNTE2YjczZGU2NmIxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.2UBPoGAHib_m5F8ANhhKnXK6FvqDeRTw08sACGE9mrk)
   > 
   > Thank you 🙏
   
   Do I need to make any further changes in this PR @alamb ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org