blaginin commented on code in PR #15258:
URL: https://github.com/apache/datafusion/pull/15258#discussion_r2010279421
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -608,19 +609,19 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
.await
.unwrap();
- let expected = [
- "+-----+----+----+",
- "| c1 | c2 | c3 |",
- "+-----+----+----+",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "+-----+----+----+",
- ];
- assert_batches_sorted_eq!(expected, &read);
+
+ insta::assert_snapshot!(batches_to_string(&read),@r###"
Review Comment:
```suggestion
insta::assert_snapshot!(batches_to_sort_string(&read),@r###"
```
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -608,19 +609,19 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
.await
.unwrap();
- let expected = [
- "+-----+----+----+",
- "| c1 | c2 | c3 |",
- "+-----+----+----+",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "| Foo | 1 | 10 |",
- "| | 2 | 20 |",
- "| bar | | |",
- "+-----+----+----+",
- ];
- assert_batches_sorted_eq!(expected, &read);
+
+ insta::assert_snapshot!(batches_to_string(&read),@r###"
Review Comment:
because it was `assert_batches_sorted_eq` before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
