YanivKunda commented on code in PR #1565:
URL: https://github.com/apache/datafusion-comet/pull/1565#discussion_r2013820176
##########
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -55,15 +55,15 @@ trait ShimCometScanExec {
protected def isNeededForSchema(sparkSchema: StructType): Boolean = false
protected def getPartitionedFile(f: FileStatusWithMetadata, p:
PartitionDirectory): PartitionedFile =
- PartitionedFileUtil.getPartitionedFile(f, p.values)
+ PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
protected def splitFiles(sparkSession: SparkSession,
file: FileStatusWithMetadata,
filePath: Path,
isSplitable: Boolean,
maxSplitBytes: Long,
partitionValues: InternalRow): Seq[PartitionedFile]
=
- PartitionedFileUtil.splitFiles(sparkSession, file, isSplitable,
maxSplitBytes, partitionValues)
+ PartitionedFileUtil.splitFiles(sparkSession, file, filePath, isSplitable,
maxSplitBytes, partitionValues)
Review Comment:
I've tried using reflection in #1573 (also adding 3.5.4 to the testing
matrix) -
Let's see how it fares.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
