alan910127 commented on code in PR #15482:
URL: https://github.com/apache/datafusion/pull/15482#discussion_r2019310584
##########
datafusion/core/tests/expr_api/mod.rs:
##########
@@ -330,12 +330,12 @@ async fn test_create_physical_expr_coercion() {
create_expr_test(lit(1i32).eq(col("id")), "CAST(1 AS Utf8) = id@0");
// compare int col to string literal `i = '202410'`
// Note this casts the column (not the field)
- create_expr_test(col("i").eq(lit("202410")), "CAST(i@1 AS Utf8) = 202410");
- create_expr_test(lit("202410").eq(col("i")), "202410 = CAST(i@1 AS Utf8)");
+ create_expr_test(col("i").eq(lit("202410")), "i@1 = 202410");
+ create_expr_test(lit("202410").eq(col("i")), "202410 = i@1");
// however, when simplified the casts on i should removed
// https://github.com/apache/datafusion/issues/14944
- create_simplified_expr_test(col("i").eq(lit("202410")), "CAST(i@1 AS Utf8)
= 202410");
- create_simplified_expr_test(lit("202410").eq(col("i")), "CAST(i@1 AS Utf8)
= 202410");
+ create_simplified_expr_test(col("i").eq(lit("202410")), "i@1 = 202410");
+ create_simplified_expr_test(lit("202410").eq(col("i")), "i@1 = 202410");
Review Comment:
not sure if this test is still needed since the literal casting behavior is
not considered an "optimization"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
