adriangb commented on PR #15561: URL: https://github.com/apache/datafusion/pull/15561#issuecomment-2779538841
Looking at the numbers I think it's noise, e.g. the biggest slowdown in the [most recent bench](https://github.com/apache/datafusion/pull/15561#issuecomment-2779497284) is: ``` -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ move-predicate ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 18 │ 248.64ms │ 274.74ms │ 1.10x slower │ └──────────────┴──────────┴────────────────┴───────────────┘ ``` But in the previous run, which included the bug causing other very large slowdowns: ``` -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ move-predicate ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 18 │ 252.59ms │ 245.94ms │ no change │ └──────────────┴──────────┴────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
