nuno-faria opened a new pull request, #15712:
URL: https://github.com/apache/datafusion/pull/15712
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- None
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The [documentation](https://datafusion.apache.org/user-guide/configs.html)
for the `datafusion.execution.target_partitions` and
`datafusion.execution.planning_concurrency` settings states that their default
values are set to 0 (which in these cases maps to the number of cores).
However, using 0 does not translate to their default values, but rather the
literal 0, which is invalid in both cases.
In a previous version, setting `datafusion.execution.target_partitions` to 0
resulted in a single partition, while in the current version it results in a
division by zero error. Likewise, setting
`datafusion.execution.planning_concurrency` to 0 causes the system to hang.
With this change, setting `datafusion.execution.target_partitions` or
`datafusion.execution.planning_concurrency` to 0 will result in the default
value being assigned instead, making it coherent with the documentation.
## What changes are included in this PR?
- `datafusion/common/config` - added the translation to the default values.
- `datafusion/execution/config` - updated the `with_target_partitions`
method.
- `sqllogictest/information_schema` - added tests.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes -- when setting these configurations to 0 -- but it will match the
existing documentation.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
