andygrove commented on code in PR #1649:
URL: https://github.com/apache/datafusion-comet/pull/1649#discussion_r2054186718
##########
native/core/src/execution/jni_api.rs:
##########
@@ -198,6 +199,7 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
task_attempt_id: jlong,
debug_native: jboolean,
explain_native: jboolean,
+ spark_conf: JObject,
Review Comment:
An alternate approach could be to encode the Spark config in protobuf format
and pass those bytes into native code rather than have native code make calls
to the JVM to iterate over the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
