mbutrovich commented on code in PR #1679:
URL: https://github.com/apache/datafusion-comet/pull/1679#discussion_r2058901724
##########
native/core/src/lib.rs:
##########
@@ -50,6 +54,10 @@ pub mod execution;
mod jvm_bridge;
pub mod parquet;
+#[cfg(all(not(target_env = "msvc"), feature = "jemalloc"))]
Review Comment:
```
cd native && RUSTFLAGS=" -Ctarget-cpu=native" cargo build --release
--features=jemalloc,mimalloc
Compiling libmimalloc-sys v0.1.42
Compiling mimalloc v0.1.46
Compiling datafusion-comet v0.8.0
(/Users/matt/git/datafusion-comet/native/core)
error[E0428]: the name `GLOBAL` is defined multiple times
--> core/src/lib.rs:63:1
|
59 | static GLOBAL: Jemalloc = Jemalloc;
| ----------------------------------- previous definition of the value
`GLOBAL` here
...
63 | static GLOBAL: MiMalloc = MiMalloc;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `GLOBAL` redefined here
|
= note: `GLOBAL` must be defined only once in the value namespace of this
module
error: cannot define multiple global allocators
--> core/src/lib.rs:63:1
|
59 | static GLOBAL: Jemalloc = Jemalloc;
| ----------------------------------- previous global allocator defined
here
...
62 | #[global_allocator]
| ------------------- in this procedural macro expansion
63 | static GLOBAL: MiMalloc = MiMalloc;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot define a new global allocator
|
= note: this error originates in the attribute macro `global_allocator`
(in Nightly builds, run with -Z macro-backtrace for more info)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
