xudong963 commented on code in PR #15995:
URL: https://github.com/apache/datafusion/pull/15995#discussion_r2081509137
##########
datafusion/physical-optimizer/src/pruning.rs:
##########
@@ -3585,12 +3605,10 @@ mod tests {
prune_with_expr(
// false
- // constant literals that do NOT refer to any columns are
currently not evaluated at all, hence the result is
- // "all true"
Review Comment:
Yes, I agree, even if it returns `true`, the query can rely on the upper
filter to do the final filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
