comphead commented on code in PR #1730:
URL: https://github.com/apache/datafusion-comet/pull/1730#discussion_r2085775857
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -625,22 +626,24 @@ impl MultiPartitionShuffleRepartitioner {
return Ok(());
}
- let num_output_partitions = self.partition_writers.len();
- let mut partitioned_batches = self.partitioned_batches();
- let mut spilled_bytes = 0;
+ with_trace("shuffle_spill", self.tracing_enabled, || {
Review Comment:
```suggestion
with_trace_async("shuffle_spill", self.tracing_enabled, || {
```
I just assumed if method is async then the `trace_async` needs to be called
like in other similar methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
