kazuyukitanimura commented on code in PR #1755:
URL: https://github.com/apache/datafusion-comet/pull/1755#discussion_r2098991685
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -1233,7 +1233,9 @@ abstract class ParquetReadSuite extends CometTestBase {
withParquetDataFrame(data, schema = Some(readSchema)) { df =>
// TODO: validate with Spark 3.x and
'usingDataFusionParquetExec=true'
- if (enableSchemaEvolution || usingDataSourceExec(conf)) {
+ if (enableSchemaEvolution || CometConf.COMET_NATIVE_SCAN_IMPL
+ .get(conf)
+ .equals(CometConf.SCAN_NATIVE_DATAFUSION)) {
Review Comment:
So schema evolution does not apply to Iceberg?
##########
common/src/main/scala/org/apache/spark/sql/comet/parquet/CometParquetReadSupport.scala:
##########
@@ -369,7 +363,7 @@ object CometParquetReadSupport {
/**
* Whether the parquet schema contains any field IDs.
*/
- private def containsFieldIds(schema: Type): Boolean = schema match {
+ def containsFieldIds(schema: Type): Boolean = schema match {
Review Comment:
Any reason that this is now public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
