mbutrovich commented on code in PR #1765:
URL: https://github.com/apache/datafusion-comet/pull/1765#discussion_r2102461675
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -133,23 +136,51 @@ class CometExecIterator(
}
}
- def getNextBatch(): Option[ColumnarBatch] = {
+ private def getNextBatch: Option[ColumnarBatch] = {
assert(partitionIndex >= 0 && partitionIndex < numParts)
if (tracingEnabled) {
traceMemoryUsage()
}
val ctx = TaskContext.get()
- withTrace(
- s"getNextBatch[JVM] stage=${ctx.stageId()}",
- tracingEnabled, {
- nativeUtil.getNextBatch(
- numOutputCols,
- (arrayAddrs, schemaAddrs) => {
- nativeLib.executePlan(ctx.stageId(), partitionIndex, plan,
arrayAddrs, schemaAddrs)
- })
- })
+
+ try {
Review Comment:
We'll have to think about that design since every error handler could
necessitate a different set of configs/context to be sent over for correct
behavior on the native side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
