alamb commented on code in PR #16142:
URL: https://github.com/apache/datafusion/pull/16142#discussion_r2109637172
##########
parquet-testing:
##########
Review Comment:
There appears to be an update of parquet-testing with unrelated content, but
I think it is ok to update it too
##########
datafusion/core/tests/user_defined/user_defined_plan.rs:
##########
@@ -796,22 +798,30 @@ fn accumulate_batch(
k: &usize,
) -> BTreeMap<i64, String> {
let num_rows = input_batch.num_rows();
+
// Assuming the input columns are
- // column[0]: customer_id / UTF8
+ // column[0]: customer_id / UTF8 or UTF8View
Review Comment:
I feel like the example would be simpler if it just used `Utf8View`. Could
we do that and avoid adding the logic to handle both types?
##########
datafusion-examples/examples/dataframe.rs:
##########
@@ -182,7 +182,11 @@ async fn write_out(ctx: &SessionContext) ->
std::result::Result<(), DataFusionEr
let mut df = ctx.sql("values ('a'), ('b'), ('c')").await.unwrap();
// Ensure the column names and types match the target table
- df = df.with_column_renamed("column1", "tablecol1").unwrap();
+ df = df
Review Comment:
I think it would be better if we could change the example to maybe just use
a `StringViewArray` in the first place (rather than have to cast it here)
##########
datafusion/sqllogictest/test_files/avro.slt:
##########
@@ -15,6 +15,10 @@
# specific language governing permissions and limitations
# under the License.
+# Currently, the avro not support Utf8View type, so we disable the
map_varchar_to_utf8view
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
