alamb commented on code in PR #16191: URL: https://github.com/apache/datafusion/pull/16191#discussion_r2109919623
########## datafusion/execution/src/disk_manager.rs: ########## @@ -91,6 +177,11 @@ pub struct DiskManager { } impl DiskManager { + /// Creates a builder for [DiskManager] + pub fn builder() -> DiskManagerBuilder { + DiskManagerBuilder::default() + } + /// Create a DiskManager given the configuration pub fn try_new(config: DiskManagerConfig) -> Result<Arc<Self>> { Review Comment: What do you think about Deprecating `DiskManagerConfig` and `DiskManager::try_new` so we have a path to a single way to configure DiskManagers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org