logan-keede commented on PR #16186: URL: https://github.com/apache/datafusion/pull/16186#issuecomment-2917721651
> Beware that this error is thrown after the planning stage has completed, and it is expected because the current limitation of subquery decorrelation. Oh I was under the impression that it was still in planning stage. Thanks for letting me know. > Looks like we need a new plan to somehow let this Optimizor back-off during the implementation of new rules 🤔 > 2\. We add a if condition inside DependentJoinRewriter, that if the deepest subquery depth is 1, it doesn't change the query plan at all > => This allow the old optimizors to work as expected. We probably should not discriminate in terms of depths, as what works for higher depth should work at depth = 1. Though I remember `Improving Unnesting of Complex Queries` mentioning the case of `Simplistic Unnesting` but I don't think that was limited by depth either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
