YanivKunda commented on code in PR #1830:
URL: https://github.com/apache/datafusion-comet/pull/1830#discussion_r2134838674
##########
pom.xml:
##########
@@ -600,7 +600,7 @@ under the License.
<!-- Use Scala 2.13 by default -->
<scala.version>2.13.14</scala.version>
Review Comment:
Scala was upgraded in the 4.0.0 release version:
```suggestion
<scala.version>2.13.16</scala.version>
```
##########
pom.xml:
##########
@@ -600,7 +600,7 @@ under the License.
<!-- Use Scala 2.13 by default -->
<scala.version>2.13.14</scala.version>
<scala.binary.version>2.13</scala.binary.version>
- <spark.version>4.0.0-preview1</spark.version>
+ <spark.version>4.0.0</spark.version>
<spark.version.short>4.0</spark.version.short>
<parquet.version>1.13.1</parquet.version>
Review Comment:
Parquet was upgraded in the 4.0.0 release version:
```suggestion
<parquet.version>1.15.2</parquet.version>
```
##########
pom.xml:
##########
@@ -600,7 +600,7 @@ under the License.
<!-- Use Scala 2.13 by default -->
<scala.version>2.13.14</scala.version>
<scala.binary.version>2.13</scala.binary.version>
- <spark.version>4.0.0-preview1</spark.version>
+ <spark.version>4.0.0</spark.version>
<spark.version.short>4.0</spark.version.short>
<parquet.version>1.13.1</parquet.version>
<semanticdb.version>4.9.5</semanticdb.version>
Review Comment:
And also, because I can't comment on the next line -
slf4j was upgraded in the 4.0.0 release version, to version 2.0.16
##########
pom.xml:
##########
@@ -600,7 +600,7 @@ under the License.
<!-- Use Scala 2.13 by default -->
<scala.version>2.13.14</scala.version>
<scala.binary.version>2.13</scala.binary.version>
- <spark.version>4.0.0-preview1</spark.version>
+ <spark.version>4.0.0</spark.version>
<spark.version.short>4.0</spark.version.short>
<parquet.version>1.13.1</parquet.version>
<semanticdb.version>4.9.5</semanticdb.version>
Review Comment:
If Scala is upgraded, this probably needs to be upgraded to:
- at least 4.12.0: the first version to support scala 2.13.16
- 4.12.7: the latest 4.12.x version
- 4.13.6: the latest of the latest
**Note**: this might need to be also aligned in the `scala-2.13` profile!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
