alamb commented on code in PR #16390:
URL: https://github.com/apache/datafusion/pull/16390#discussion_r2145093532
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -718,8 +718,6 @@ struct NestedLoopJoinStream<T> {
inner_table: OnceFut<JoinLeftData>,
/// Information of index and left / right placement of columns
column_indices: Vec<ColumnIndex>,
- // TODO: support null aware equal
Review Comment:
Rather than just deleting this, Maybe we can add a comment explaining the
rationale for why it doesn't need null_equals_null.
```suggestion
// No need to support null aware equal because ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
