alamb commented on PR #15770: URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971173365
> > QQuery 25 │ 380.03 ms │ 279.23 ms │ +1.36x faster > > ```sql > SELECT SearchPhrase FROM hits WHERE SearchPhrase <> '' ORDER BY SearchPhrase LIMIT 10; > ``` > > Looks like it might be real! > > And obviously we expect Q23 to get a huge bump once we enable filter pushdown... > > I think the only thing left here is for someone to review in detail 😄 I can reproduce this improvement locally. I tested using ```shell $ cat q25.sql SELECT "SearchPhrase" FROM hits WHERE "SearchPhrase" <> '' ORDER BY "SearchPhrase" LIMIT 10; $ ./datafusion-cli-topk-dynamic-filters -f q25.sql ... ``` main (merge-base) ``` Elapsed 0.209 seconds. Elapsed 0.214 seconds. Elapsed 0.210 seconds. ``` This branch ``` Elapsed 0.173 seconds. Elapsed 0.182 seconds. Elapsed 0.178 seconds. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
