xudong963 commented on issue #16188: URL: https://github.com/apache/datafusion/issues/16188#issuecomment-2990200877
@kosiew 's suggestions look good to me, I have one another question: **FilterPushdownPhase::Pre** IMO, `FilterPushdownPhase::Pre` runs before most other physical optimizations, It only handles "static filters that do not reference any ExecutionPlans", this type of static filter pushdown should logically belong in the logical optimization phase. Is there a duplication with `push_down_filter` in the logical optimizer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
