andygrove commented on code in PR #1920:
URL: https://github.com/apache/datafusion-comet/pull/1920#discussion_r2162206037
##########
common/src/main/java/org/apache/comet/parquet/ColumnReader.java:
##########
@@ -126,6 +126,13 @@ public void setPageReader(PageReader pageReader) throws
IOException {
}
}
+ /** This method is called from Apache Iceberg. */
+ public void setRowGroupReader(RowGroupReader rowGroupReader,
ParquetColumnSpec columnSpec)
Review Comment:
It would be good to have some unit tests in Comet for the methods intended
to be called from Iceberg, so that we catch any regressions in behavior. This
could be added as a separate PR so that we don't slow down progress on the
integration work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
