andygrove commented on code in PR #1951:
URL: https://github.com/apache/datafusion-comet/pull/1951#discussion_r2173395678
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -2681,7 +2681,7 @@ mod tests {
assert_eq!(casted.value(0), 42000000);
// https://github.com/apache/datafusion-comet/issues/1371
// assert_eq!(casted.value(1), 515313);
- assert_eq!(casted.value(2), -42424242);
+ // assert_eq!(casted.value(2), -42424242);
Review Comment:
@leung-ming Thanks for catching this issue and explaining the root cause.
Rather than change the test, could you skip this test during miri runs by
adding the `#[cfg_attr(miri, ignore)]` annotation along with a brief comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
