LiaCastaneda commented on code in PR #16445: URL: https://github.com/apache/datafusion/pull/16445#discussion_r2184901077
########## datafusion/physical-plan/src/joins/hash_join.rs: ########## @@ -1039,12 +1196,50 @@ async fn collect_left_input( let data = JoinLeftData::new( hashmap, single_batch, - left_values, + left_values.clone(), Mutex::new(visited_indices_bitmap), AtomicUsize::new(probe_threads_count), reservation, ); + // Update dynamic filter with min/max bounds if provided + if num_rows > 0 { Review Comment: should we avoid computing these bounds if `enable_dynamic_filter_pushdown` is not enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org