liamzwbao commented on code in PR #16686:
URL: https://github.com/apache/datafusion/pull/16686#discussion_r2186078102
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -289,7 +289,7 @@ fn test_no_pushdown_through_aggregates() {
Ok:
- FilterExec: b@1 = bar
- CoalesceBatchesExec: target_batch_size=100
- - AggregateExec: mode=Final, gby=[a@0 as a, b@1 as b], aggr=[cnt]
+ - AggregateExec: mode=Final, gby=[a@0 as a, b@1 as b],
aggr=[cnt], ordering_mode=PartiallySorted([0])
Review Comment:
This is a side effect for the fix, but I think it's okay as it preserves the
`ordering_mode` instead of defaulting it to `Linear`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
