Samyak2 commented on PR #16500:
URL: https://github.com/apache/datafusion/pull/16500#issuecomment-3039543288
I have added asserts for metrics in the existing join tests. The ones in
hash_join and cross_join are working. The asserts in nested_loop_join are
currently failing due to a mismatch in `output_rows`. I'm debugging this, but I
have put this out here in case anyone has an idea about this (or if this is
expected):
```
failures:
---- joins::nested_loop_join::tests::join_left_anti_with_filter stdout ----
thread 'joins::nested_loop_join::tests::join_left_anti_with_filter' panicked
at datafusion/physical-plan/src/joins/nested_loop_join.rs:1405:9:
assertion `left == right` failed
left: 0
right: 2
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- joins::nested_loop_join::tests::join_left_semi_with_filter stdout ----
thread 'joins::nested_loop_join::tests::join_left_semi_with_filter' panicked
at datafusion/physical-plan/src/joins/nested_loop_join.rs:1375:9:
assertion `left == right` failed
left: 0
right: 1
---- joins::nested_loop_join::tests::join_left_with_filter stdout ----
thread 'joins::nested_loop_join::tests::join_left_with_filter' panicked at
datafusion/physical-plan/src/joins/nested_loop_join.rs:1282:9:
assertion `left == right` failed
left: 1
right: 3
---- joins::nested_loop_join::tests::join_full_with_filter stdout ----
thread 'joins::nested_loop_join::tests::join_full_with_filter' panicked at
datafusion/physical-plan/src/joins/nested_loop_join.rs:1346:9:
assertion `left == right` failed
left: 3
right: 5
---- joins::nested_loop_join::tests::join_left_mark_with_filter stdout ----
thread 'joins::nested_loop_join::tests::join_left_mark_with_filter' panicked
at datafusion/physical-plan/src/joins/nested_loop_join.rs:1495:9:
assertion `left == right` failed
left: 0
right: 3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
