zhuqi-lucas commented on PR #16711: URL: https://github.com/apache/datafusion/pull/16711#issuecomment-3052815314
> One thing that I think has caused us problems is judging any improvements to pushdown based on not regressing performance when pushdown is enabled vs not. > > However, this makes making incremental progress really hard. What I think we should start doing is compare any proposed improvements to pushdown when pushdown is already on. > > In other words, let's make a benchmark that already has filter pushdown on. > > I'll make a PR for this new benchmark later today Great point @alamb , i totally agree this, we can first improve the pushdown itself instead of comparing to not pushdown because we currently not default pushdown until now. I guess this PR and https://github.com/apache/datafusion/pull/16562 will improve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
