yoavcloud commented on code in PR #1931:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1931#discussion_r2199758669
##########
tests/sqlparser_snowflake.rs:
##########
@@ -995,6 +995,21 @@ fn test_snowflake_create_iceberg_table_without_location() {
);
}
+#[test]
+fn test_snowflake_create_table_trailing_options() {
+ snowflake()
+ .parse_sql_statements(
+ "CREATE TEMP TABLE dst AS (SELECT * FROM src) ON COMMIT PRESERVE
ROWS",
+ )
+ .unwrap();
+ snowflake()
+ .parse_sql_statements("CREATE TEMP TABLE tbl LIKE customers ON COMMIT
PRESERVE ROWS;")
+ .unwrap();
+ snowflake()
+ .parse_sql_statements("CREATE TEMP TABLE tbl CLONE customers ON COMMIT
PRESERVE ROWS;")
+ .unwrap();
Review Comment:
Improved the tests, note Snowflake supports specifying the options either
before or after the "source" definition while the SQL output assumes one. Added
tests for both options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
