iffyio commented on code in PR #1937:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1937#discussion_r2200209520
##########
src/parser/mod.rs:
##########
@@ -222,13 +222,17 @@ pub struct ParserOptions {
/// Controls how literal values are unescaped. See
/// [`Tokenizer::with_unescape`] for more details.
pub unescape: bool,
+ /// Controls if the parser expects a semi-colon token
+ /// between statements.
Review Comment:
Thinking it might be helpful if we include in the doc that the default is
true?
##########
tests/sqlparser_mssql.rs:
##########
@@ -2480,3 +2492,15 @@ fn parse_mssql_grant() {
fn parse_mssql_deny() {
ms().verified_stmt("DENY SELECT ON my_table TO public, db_admin");
}
+
+#[test]
Review Comment:
Could we have a similar test or move this over to common.rs? thinking since
this flag is being added to the parser itself, it feels a bit like it could be
lost if only tested here within mssql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
