haohuaijin commented on code in PR #16762:
URL: https://github.com/apache/datafusion/pull/16762#discussion_r2206127215
##########
datafusion/physical-expr/src/utils/guarantee.rs:
##########
@@ -824,13 +894,87 @@ mod test {
);
}
+ #[test]
+ fn test_disjunction_and_conjunction_multi_column() {
+ // (a = "foo" AND b = 1) OR (a = "bar" AND b = 2)
Review Comment:
add in 89dc6be, and
for `(a IN ("foo", "bar") AND b = 5) OR (a IN ("foo") AND b=6)`, i think the
guarantee should be `a in ("foo", "bar")`, because if `a = "bar"`, the expr
also can be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
