adamreeve commented on code in PR #16649:
URL: https://github.com/apache/datafusion/pull/16649#discussion_r2206231243
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -959,14 +953,18 @@ pub async fn fetch_parquet_metadata(
store: &dyn ObjectStore,
meta: &ObjectMeta,
size_hint: Option<usize>,
- decryption_properties: Option<&FileDecryptionProperties>,
+ #[allow(unused)] decryption_properties: Option<&FileDecryptionProperties>,
Review Comment:
One nice effect of this would be that it would allow removing the need to
define `FileDecryptionProperties` as an empty struct when the encryption
feature is disabled, as I think this is the only place it appears in a public
API that isn't an encryption specific method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
