findepi commented on PR #16781: URL: https://github.com/apache/datafusion/pull/16781#issuecomment-3073335642
> The approach looks very reasonable, but there is a _lot_ of boiler plate code. I'm guessing there wasn't an easier way to add some derived traits for `PartialEq` and `Hash` for these structs instead. It would work for some, but not all. If we want ptr eq for an Arc, we need hand-written eq and hash anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
