alamb commented on code in PR #16539:
URL: https://github.com/apache/datafusion/pull/16539#discussion_r2216741569
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -3075,38 +3075,7 @@ impl ScalarValue {
target_type: &DataType,
cast_options: &CastOptions<'static>,
) -> Result<Self> {
- let scalar_array = match (self, target_type) {
- (
- ScalarValue::Decimal128(Some(decimal_value), _, scale),
- DataType::Timestamp(time_unit, None),
- ) => {
- let scale_factor = 10_i128.pow(*scale as u32);
- let seconds = decimal_value / scale_factor;
- let fraction = decimal_value % scale_factor;
-
- let timestamp_value = match time_unit {
- TimeUnit::Second => ScalarValue::Int64(Some(seconds as
i64)),
- TimeUnit::Millisecond => {
- let millis = seconds * 1_000 + (fraction * 1_000) /
scale_factor;
- ScalarValue::Int64(Some(millis as i64))
- }
- TimeUnit::Microsecond => {
- let micros =
- seconds * 1_000_000 + (fraction * 1_000_000) /
scale_factor;
- ScalarValue::Int64(Some(micros as i64))
- }
- TimeUnit::Nanosecond => {
- let nanos = seconds * 1_000_000_000
- + (fraction * 1_000_000_000) / scale_factor;
- ScalarValue::Int64(Some(nanos as i64))
- }
- };
-
- timestamp_value.to_array()?
- }
- _ => self.to_array()?,
- };
-
+ let scalar_array = self.to_array()?;
Review Comment:
that is pretty nice fixing bugs by deleting code 🏆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
