alamb commented on code in PR #16846:
URL: https://github.com/apache/datafusion/pull/16846#discussion_r2222178654
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -434,13 +448,17 @@ impl AsyncScalarUDFImpl for AsyncUpper {
Some(10)
}
+ /// This method is called to execute the async UDF and is similar
+ /// to the normal `invoke_with_args` except it returns an `ArrayRef`
+ /// instead of `ColumnarValue` and is `async`.
Review Comment:
I don't know if there is any reason this API doesn't return `ColumnarValue`
consistently with the ScalarUDFImpl -- @goldmedal do you remember if there is
any reason?
If not, I can file a ticket to make the APIs consistent
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -345,12 +354,17 @@ async fn main() {
}
```
-## Adding a Scalar Async UDF
+## Adding a Async Scalar UDF
-A Scalar Async UDF allows you to implement user-defined functions that support
+An `Async` Scalar UDF allows you to implement user-defined functions that
support
asynchronous execution, such as performing network or I/O operations within the
UDF.
+:::{note}
+DataFusion `49.0.0`
+: This feature requires DataFusion version `49.0.0` or later.
Review Comment:
I will remove this
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -419,6 +432,7 @@ impl ScalarUDFImpl for AsyncUpper {
Ok(DataType::Utf8)
}
+ // Note the normal invoke_with_args method is not called for Async UDFs
Review Comment:
Yeah, we could potentially refactor the traits a bit more to avoid this, but
I think that might cause more API churn than the value it added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
