theirix commented on issue #16545:
URL: https://github.com/apache/datafusion/issues/16545#issuecomment-3104952628
> > I expect the physical plan optimiser doesn't perform pushdown of
volatile predicates.
>
> I am not sure -- does this result in wrong results?
We don't observe incorrect results (as was the case with the logical
optimiser bug when evaluating a predicate twice).
It can produce skewed or non-reproducible results if a volatile predicate
evaluates to different values for different row groups (I can create a test to
reproduce it).
It could probably affect the table sampling implementation #16325 , which
relies on inserting a volatile filter.
> It does make sense in general to have the physical pushdown optimizer
follow the same behavior as the logical optimizer
Yes, it is a reasonable assumption about an optimiser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
