chenkovsky commented on code in PR #1969:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1969#discussion_r2225764102


##########
src/ast/query.rs:
##########
@@ -1351,9 +1392,9 @@ pub enum TableFactor {
     /// See <https://docs.snowflake.com/en/sql-reference/constructs/unpivot>.
     Unpivot {
         table: Box<TableFactor>,
-        value: Ident,
+        value: Vec<Ident>,

Review Comment:
   should we use expr::Identifier ? otherwise we cannot visit this ident by 
vistor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to